| From ecf0eb9edbb607d74f74b73c14af8b43f3729528 Mon Sep 17 00:00:00 2001 |
| From: Nickolai Zeldovich <nickolai@csail.mit.edu> |
| Date: Sat, 5 Jan 2013 14:19:51 -0500 |
| Subject: nfs: avoid dereferencing null pointer in initiate_bulk_draining |
| |
| From: Nickolai Zeldovich <nickolai@csail.mit.edu> |
| |
| commit ecf0eb9edbb607d74f74b73c14af8b43f3729528 upstream. |
| |
| Fix an inverted null pointer check in initiate_bulk_draining(). |
| |
| Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu> |
| Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/nfs/callback_proc.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/nfs/callback_proc.c |
| +++ b/fs/nfs/callback_proc.c |
| @@ -205,7 +205,7 @@ static u32 initiate_bulk_draining(struct |
| |
| list_for_each_entry(lo, &server->layouts, plh_layouts) { |
| ino = igrab(lo->plh_inode); |
| - if (ino) |
| + if (!ino) |
| continue; |
| spin_lock(&ino->i_lock); |
| /* Is this layout in the process of being freed? */ |
