| From 39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8 Mon Sep 17 00:00:00 2001 |
| From: Yanchuan Nian <ycnian@gmail.com> |
| Date: Fri, 4 Jan 2013 20:19:49 +0800 |
| Subject: pnfs: Increase the refcount when LAYOUTGET fails the first time |
| |
| From: Yanchuan Nian <ycnian@gmail.com> |
| |
| commit 39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8 upstream. |
| |
| The layout will be set unusable if LAYOUTGET fails. Is it reasonable to |
| increase the refcount iff LAYOUTGET fails the first time? |
| |
| Signed-off-by: Yanchuan Nian <ycnian@gmail.com> |
| Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/nfs/pnfs.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/nfs/pnfs.c |
| +++ b/fs/nfs/pnfs.c |
| @@ -254,7 +254,7 @@ static void |
| pnfs_layout_set_fail_bit(struct pnfs_layout_hdr *lo, int fail_bit) |
| { |
| lo->plh_retry_timestamp = jiffies; |
| - if (test_and_set_bit(fail_bit, &lo->plh_flags)) |
| + if (!test_and_set_bit(fail_bit, &lo->plh_flags)) |
| atomic_inc(&lo->plh_refcount); |
| } |
| |
