| From 8d238027b87e654be552eabdf492042a34c5c300 Mon Sep 17 00:00:00 2001 |
| From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| Date: Mon, 17 Dec 2012 16:03:17 -0800 |
| Subject: proc: pid/status: show all supplementary groups |
| |
| From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| |
| commit 8d238027b87e654be552eabdf492042a34c5c300 upstream. |
| |
| We display a list of supplementary group for each process in |
| /proc/<pid>/status. However, we show only the first 32 groups, not all of |
| them. |
| |
| Although this is rare, but sometimes processes do have more than 32 |
| supplementary groups, and this kernel limitation breaks user-space apps |
| that rely on the group list in /proc/<pid>/status. |
| |
| Number 32 comes from the internal NGROUPS_SMALL macro which defines the |
| length for the internal kernel "small" groups buffer. There is no |
| apparent reason to limit to this value. |
| |
| This patch removes the 32 groups printing limit. |
| |
| The Linux kernel limits the amount of supplementary groups by NGROUPS_MAX, |
| which is currently set to 65536. And this is the maximum count of groups |
| we may possibly print. |
| |
| Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com> |
| Acked-by: Kees Cook <keescook@chromium.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/proc/array.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/proc/array.c |
| +++ b/fs/proc/array.c |
| @@ -212,7 +212,7 @@ static inline void task_state(struct seq |
| group_info = cred->group_info; |
| task_unlock(p); |
| |
| - for (g = 0; g < min(group_info->ngroups, NGROUPS_SMALL); g++) |
| + for (g = 0; g < group_info->ngroups; g++) |
| seq_printf(m, "%d ", |
| from_kgid_munged(user_ns, GROUP_AT(group_info, g))); |
| put_cred(cred); |