| From 98c35534420d3147553bd3071a5fc63cd56de5b1 Mon Sep 17 00:00:00 2001 |
| From: Lothar Waßmann <LW@KARO-electronics.de> |
| Date: Thu, 22 Nov 2012 10:11:25 +0100 |
| Subject: USB: chipidea: fix use after free bug |
| |
| From: Lothar Waßmann <LW@KARO-electronics.de> |
| |
| commit 98c35534420d3147553bd3071a5fc63cd56de5b1 upstream. |
| |
| The pointer to a platform_device struct must not be dereferenced after |
| the device has been unregistered. |
| |
| This bug produces a crash when unloading the ci13xxx kernel module |
| compiled with CONFIG_PAGE_POISONING enabled. |
| |
| Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> |
| Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/chipidea/core.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/chipidea/core.c |
| +++ b/drivers/usb/chipidea/core.c |
| @@ -385,8 +385,9 @@ EXPORT_SYMBOL_GPL(ci13xxx_add_device); |
| |
| void ci13xxx_remove_device(struct platform_device *pdev) |
| { |
| + int id = pdev->id; |
| platform_device_unregister(pdev); |
| - ida_simple_remove(&ci_ida, pdev->id); |
| + ida_simple_remove(&ci_ida, id); |
| } |
| EXPORT_SYMBOL_GPL(ci13xxx_remove_device); |
| |
