| From 681ab4696062f5aa939c9e04d058732306a97176 Mon Sep 17 00:00:00 2001 |
| From: Jes Sorensen <Jes.Sorensen@redhat.com> |
| Date: Tue, 20 Oct 2015 12:09:13 -0400 |
| Subject: md/raid10: submit_bio_wait() returns 0 on success |
| |
| From: Jes Sorensen <Jes.Sorensen@redhat.com> |
| |
| commit 681ab4696062f5aa939c9e04d058732306a97176 upstream. |
| |
| This was introduced with 9e882242c6193ae6f416f2d8d8db0d9126bd996b |
| which changed the return value of submit_bio_wait() to return != 0 on |
| error, but didn't update the caller accordingly. |
| |
| Fixes: 9e882242c6 ("block: Add submit_bio_wait(), remove from md") |
| Reported-by: Bill Kuzeja <William.Kuzeja@stratus.com> |
| Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> |
| Signed-off-by: NeilBrown <neilb@suse.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/md/raid10.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/md/raid10.c |
| +++ b/drivers/md/raid10.c |
| @@ -2590,7 +2590,7 @@ static int narrow_write_error(struct r10 |
| choose_data_offset(r10_bio, rdev) + |
| (sector - r10_bio->sector)); |
| wbio->bi_bdev = rdev->bdev; |
| - if (submit_bio_wait(WRITE, wbio) == 0) |
| + if (submit_bio_wait(WRITE, wbio) < 0) |
| /* Failure! */ |
| ok = rdev_set_badblocks(rdev, sector, |
| sectors, 0) |
