| From 9180bb4f046064dfa4541488102703b402bb04e1 Mon Sep 17 00:00:00 2001 |
| From: Eric Dumazet <edumazet@google.com> |
| Date: Sat, 16 Mar 2019 13:09:53 -0700 |
| Subject: tun: add a missing rcu_read_unlock() in error path |
| |
| From: Eric Dumazet <edumazet@google.com> |
| |
| commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream. |
| |
| In my latest patch I missed one rcu_read_unlock(), in case |
| device is down. |
| |
| Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") |
| Signed-off-by: Eric Dumazet <edumazet@google.com> |
| Reported-by: syzbot <syzkaller@googlegroups.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/tun.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/net/tun.c |
| +++ b/drivers/net/tun.c |
| @@ -1569,6 +1569,7 @@ drop: |
| rcu_read_lock(); |
| if (unlikely(!(tun->dev->flags & IFF_UP))) { |
| err = -EIO; |
| + rcu_read_unlock(); |
| goto drop; |
| } |
| |
