| From fad3c231ff383d8dde710456d7757ef14c3c6a38 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Fri, 22 Mar 2019 11:04:08 +0800 |
| Subject: net: ibm: fix possible object reference leak |
| |
| [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] |
| |
| The call to ehea_get_eth_dn returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Douglas Miller <dougmill@linux.ibm.com> |
| Cc: "David S. Miller" <davem@davemloft.net> |
| Cc: netdev@vger.kernel.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c |
| index 4878b7169e0f..30cbdf0fed59 100644 |
| --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c |
| +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c |
| @@ -3176,6 +3176,7 @@ static ssize_t ehea_probe_port(struct device *dev, |
| |
| if (ehea_add_adapter_mr(adapter)) { |
| pr_err("creating MR failed\n"); |
| + of_node_put(eth_dn); |
| return -EIO; |
| } |
| |
| -- |
| 2.19.1 |
| |
