| From 768e2c0b96d49a56a2dbed2d15b8f5897069c23f Mon Sep 17 00:00:00 2001 |
| From: Aditya Pakki <pakki001@umn.edu> |
| Date: Wed, 20 Mar 2019 10:42:32 -0500 |
| Subject: staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc |
| |
| [ Upstream commit 6a8ca24590a2136921439b376c926c11a6effc0e ] |
| |
| phydm.internal is allocated using kzalloc which is used multiple |
| times without a check for NULL pointer. This patch avoids such a |
| scenario by returning 0, consistent with the failure case. |
| |
| Signed-off-by: Aditya Pakki <pakki001@umn.edu> |
| Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org> |
| --- |
| drivers/staging/rtlwifi/phydm/rtl_phydm.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c |
| index 85e490d3601f..cab563fefc34 100644 |
| --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c |
| +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c |
| @@ -191,6 +191,8 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv, |
| |
| rtlpriv->phydm.internal = |
| kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL); |
| + if (!rtlpriv->phydm.internal) |
| + return 0; |
| |
| _rtl_phydm_init_com_info(rtlpriv, ic, params); |
| |
| -- |
| 2.19.1 |
| |
