| From 045f0a9f0e3f70f4afc60152f036878365356da0 Mon Sep 17 00:00:00 2001 |
| From: Aditya Pakki <pakki001@umn.edu> |
| Date: Wed, 20 Mar 2019 12:02:49 -0500 |
| Subject: staging: rtlwifi: rtl8822b: fix to avoid potential NULL pointer |
| dereference |
| |
| [ Upstream commit d70d70aec9632679dd00dcc1b1e8b2517e2c7da0 ] |
| |
| skb allocated via dev_alloc_skb can fail and return a NULL pointer. |
| This patch avoids such a scenario and returns, consistent with other |
| invocations. |
| |
| Signed-off-by: Aditya Pakki <pakki001@umn.edu> |
| Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org> |
| --- |
| drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c |
| index acabb2470d55..02ca3157c5a5 100644 |
| --- a/drivers/staging/rtlwifi/rtl8822be/fw.c |
| +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c |
| @@ -752,6 +752,8 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) |
| u1_rsvd_page_loc, 3); |
| |
| skb = dev_alloc_skb(totalpacketlen); |
| + if (!skb) |
| + return; |
| memcpy((u8 *)skb_put(skb, totalpacketlen), &reserved_page_packet, |
| totalpacketlen); |
| |
| -- |
| 2.19.1 |
| |
