| From a068aab42258e25094bc2c159948d263ed7d7a77 Mon Sep 17 00:00:00 2001 |
| From: Qiushi Wu <wu000273@umn.edu> |
| Date: Wed, 27 May 2020 22:10:29 -0500 |
| Subject: bonding: Fix reference count leak in bond_sysfs_slave_add. |
| |
| From: Qiushi Wu <wu000273@umn.edu> |
| |
| commit a068aab42258e25094bc2c159948d263ed7d7a77 upstream. |
| |
| kobject_init_and_add() takes reference even when it fails. |
| If this function returns an error, kobject_put() must be called to |
| properly clean up the memory associated with the object. Previous |
| commit "b8eb718348b8" fixed a similar problem. |
| |
| Fixes: 07699f9a7c8d ("bonding: add sysfs /slave dir for bond slave devices.") |
| Signed-off-by: Qiushi Wu <wu000273@umn.edu> |
| Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/bonding/bond_sysfs_slave.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/net/bonding/bond_sysfs_slave.c |
| +++ b/drivers/net/bonding/bond_sysfs_slave.c |
| @@ -153,8 +153,10 @@ int bond_sysfs_slave_add(struct slave *s |
| |
| err = kobject_init_and_add(&slave->kobj, &slave_ktype, |
| &(slave->dev->dev.kobj), "bonding_slave"); |
| - if (err) |
| + if (err) { |
| + kobject_put(&slave->kobj); |
| return err; |
| + } |
| |
| for (a = slave_attrs; *a; ++a) { |
| err = sysfs_create_file(&slave->kobj, &((*a)->attr)); |
