| From foo@baz Mon Sep 17 12:33:31 CEST 2018 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Wed, 20 Jun 2018 13:39:53 +0300 |
| Subject: f2fs: Fix uninitialized return in f2fs_ioc_shutdown() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 2a96d8ad94ce57cb0072f7a660b1039720c47716 ] |
| |
| "ret" can be uninitialized on the success path when "in == |
| F2FS_GOING_DOWN_FULLSYNC". |
| |
| Fixes: 60b2b4ee2bc0 ("f2fs: Fix deadlock in shutdown ioctl") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Chao Yu <yuchao0@huawei.com> |
| Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/f2fs/file.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/f2fs/file.c |
| +++ b/fs/f2fs/file.c |
| @@ -1803,7 +1803,7 @@ static int f2fs_ioc_shutdown(struct file |
| struct f2fs_sb_info *sbi = F2FS_I_SB(inode); |
| struct super_block *sb = sbi->sb; |
| __u32 in; |
| - int ret; |
| + int ret = 0; |
| |
| if (!capable(CAP_SYS_ADMIN)) |
| return -EPERM; |
