| From foo@baz Mon Sep 17 13:33:56 CEST 2018 |
| From: Stephen Hemminger <stephen@networkplumber.org> |
| Date: Thu, 13 Sep 2018 07:58:59 -0700 |
| Subject: ipv4: frags: precedence bug in ip_expire() |
| To: davem@davemloft.net, gregkh@linuxfoundation.org |
| Cc: netdev@vger.kernel.org, stable@vger.kernel.org, edumazet@google.com, Dan Carpenter <dan.carpenter@oracle.com> |
| Message-ID: <20180913145902.17531-28-sthemmin@microsoft.com> |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| We accidentally removed the parentheses here, but they are required |
| because '!' has higher precedence than '&'. |
| |
| Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit 70837ffe3085c9a91488b52ca13ac84424da1042) |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/ipv4/ip_fragment.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/ipv4/ip_fragment.c |
| +++ b/net/ipv4/ip_fragment.c |
| @@ -154,7 +154,7 @@ static void ip_expire(struct timer_list |
| __IP_INC_STATS(net, IPSTATS_MIB_REASMFAILS); |
| __IP_INC_STATS(net, IPSTATS_MIB_REASMTIMEOUT); |
| |
| - if (!qp->q.flags & INET_FRAG_FIRST_IN) |
| + if (!(qp->q.flags & INET_FRAG_FIRST_IN)) |
| goto out; |
| |
| /* sk_buff::dev and sk_buff::rbnode are unionized. So we |
