| From foo@baz Mon Sep 17 12:33:31 CEST 2018 |
| From: Yelena Krivosheev <yelena@marvell.com> |
| Date: Wed, 18 Jul 2018 18:10:51 +0200 |
| Subject: net: mvneta: fix mtu change on port without link |
| |
| From: Yelena Krivosheev <yelena@marvell.com> |
| |
| [ Upstream commit 8466baf788ec3e18836bd9c91ba0b1a07af25878 ] |
| |
| It is incorrect to enable TX/RX queues (call by mvneta_port_up()) for |
| port without link. Indeed MTU change for interface without link causes TX |
| queues to stuck. |
| |
| Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP |
| network unit") |
| Signed-off-by: Yelena Krivosheev <yelena@marvell.com> |
| [gregory.clement: adding Fixes tags and rewording commit log] |
| Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/marvell/mvneta.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/marvell/mvneta.c |
| +++ b/drivers/net/ethernet/marvell/mvneta.c |
| @@ -3195,7 +3195,6 @@ static int mvneta_change_mtu(struct net_ |
| |
| on_each_cpu(mvneta_percpu_enable, pp, true); |
| mvneta_start_dev(pp); |
| - mvneta_port_up(pp); |
| |
| netdev_update_features(dev); |
| |