| From foo@baz Mon Sep 17 12:33:31 CEST 2018 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Thu, 19 Jul 2018 11:16:48 +0300 |
| Subject: pinctrl: imx: off by one in imx_pinconf_group_dbg_show() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit b4859f3edb47825f62d1b2efdd75fe7945996f49 ] |
| |
| The > should really be >= here. It's harmless because |
| pinctrl_generic_get_group() will return a NULL if group is invalid. |
| |
| Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver") |
| Reported-by: Dong Aisheng <aisheng.dong@nxp.com> |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/pinctrl/freescale/pinctrl-imx.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/pinctrl/freescale/pinctrl-imx.c |
| +++ b/drivers/pinctrl/freescale/pinctrl-imx.c |
| @@ -389,7 +389,7 @@ static void imx_pinconf_group_dbg_show(s |
| const char *name; |
| int i, ret; |
| |
| - if (group > pctldev->num_groups) |
| + if (group >= pctldev->num_groups) |
| return; |
| |
| seq_printf(s, "\n"); |
