| From 05ab9d45b47fdf8dfb73d03c555affc53e343644 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 17 Jan 2022 05:09:40 +0100 |
| Subject: ARM: 9178/1: fix unmet dependency on BITREVERSE for |
| HAVE_ARCH_BITREVERSE |
| |
| From: Julian Braha <julianbraha@gmail.com> |
| |
| [ Upstream commit 11c57c3ba94da74c3446924260e34e0b1950b5d7 ] |
| |
| Resending this to properly add it to the patch tracker - thanks for letting |
| me know, Arnd :) |
| |
| When ARM is enabled, and BITREVERSE is disabled, |
| Kbuild gives the following warning: |
| |
| WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE |
| Depends on [n]: BITREVERSE [=n] |
| Selected by [y]: |
| - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n] |
| |
| This is because ARM selects HAVE_ARCH_BITREVERSE |
| without selecting BITREVERSE, despite |
| HAVE_ARCH_BITREVERSE depending on BITREVERSE. |
| |
| This unmet dependency bug was found by Kismet, |
| a static analysis tool for Kconfig. Please advise if this |
| is not the appropriate solution. |
| |
| Signed-off-by: Julian Braha <julianbraha@gmail.com> |
| Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| lib/Kconfig | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/lib/Kconfig b/lib/Kconfig |
| index a3928d4438b5..714ec2f50bb1 100644 |
| --- a/lib/Kconfig |
| +++ b/lib/Kconfig |
| @@ -16,7 +16,6 @@ config BITREVERSE |
| config HAVE_ARCH_BITREVERSE |
| bool |
| default n |
| - depends on BITREVERSE |
| help |
| This option enables the use of hardware bit-reversal instructions on |
| architectures which support such operations. |
| -- |
| 2.34.1 |
| |
