| From e4b3b898652fca12c9041374ff1e6aefeb9fb0a8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 27 Aug 2018 12:21:45 +0300 |
| Subject: ALSA: pcm: signedness bug in snd_pcm_plug_alloc() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 6f128fa41f310e1f39ebcea9621d2905549ecf52 ] |
| |
| The "frames" variable is unsigned so the error handling doesn't work |
| properly. |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/core/oss/pcm_plugin.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/sound/core/oss/pcm_plugin.c b/sound/core/oss/pcm_plugin.c |
| index 71571d9921598..31cb2acf8afcc 100644 |
| --- a/sound/core/oss/pcm_plugin.c |
| +++ b/sound/core/oss/pcm_plugin.c |
| @@ -111,7 +111,7 @@ int snd_pcm_plug_alloc(struct snd_pcm_substream *plug, snd_pcm_uframes_t frames) |
| while (plugin->next) { |
| if (plugin->dst_frames) |
| frames = plugin->dst_frames(plugin, frames); |
| - if (snd_BUG_ON(frames <= 0)) |
| + if (snd_BUG_ON((snd_pcm_sframes_t)frames <= 0)) |
| return -ENXIO; |
| plugin = plugin->next; |
| err = snd_pcm_plugin_alloc(plugin, frames); |
| @@ -123,7 +123,7 @@ int snd_pcm_plug_alloc(struct snd_pcm_substream *plug, snd_pcm_uframes_t frames) |
| while (plugin->prev) { |
| if (plugin->src_frames) |
| frames = plugin->src_frames(plugin, frames); |
| - if (snd_BUG_ON(frames <= 0)) |
| + if (snd_BUG_ON((snd_pcm_sframes_t)frames <= 0)) |
| return -ENXIO; |
| plugin = plugin->prev; |
| err = snd_pcm_plugin_alloc(plugin, frames); |
| -- |
| 2.20.1 |
| |
