| From ba60cf9f78f0d7c8e73c7390608f7f818ee68aa0 Mon Sep 17 00:00:00 2001 |
| From: Chuhong Yuan <hslester96@gmail.com> |
| Date: Fri, 15 Nov 2019 11:32:36 -0800 |
| Subject: Input: synaptics-rmi4 - destroy F54 poller workqueue when removing |
| |
| From: Chuhong Yuan <hslester96@gmail.com> |
| |
| commit ba60cf9f78f0d7c8e73c7390608f7f818ee68aa0 upstream. |
| |
| The driver forgets to destroy workqueue in remove() similarly to what is |
| done when probe() fails. Add a call to destroy_workqueue() to fix it. |
| |
| Since unregistration will wait for the work to finish, we do not need to |
| cancel/flush the work instance in remove(). |
| |
| Signed-off-by: Chuhong Yuan <hslester96@gmail.com> |
| Cc: stable@vger.kernel.org |
| Link: https://lore.kernel.org/r/20191114023405.31477-1-hslester96@gmail.com |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/input/rmi4/rmi_f54.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/input/rmi4/rmi_f54.c |
| +++ b/drivers/input/rmi4/rmi_f54.c |
| @@ -742,6 +742,7 @@ static void rmi_f54_remove(struct rmi_fu |
| |
| video_unregister_device(&f54->vdev); |
| v4l2_device_unregister(&f54->v4l2); |
| + destroy_workqueue(f54->workqueue); |
| } |
| |
| struct rmi_function_handler rmi_f54_handler = { |
