| From 1dde09cec43aa71e0c30c6a3adc94b67118e397c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 21 Jun 2018 15:32:48 -0500 |
| Subject: ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address |
| |
| From: Corey Minyard <cminyard@mvista.com> |
| |
| [ Upstream commit 1574608f5f4204440d6d9f52b971aba967664764 ] |
| |
| Looking at logs from systems all over the place, it looks like tons |
| of broken systems exist that set the base address to zero. I can |
| only guess that is some sort of non-standard idea to mark the |
| interface as not being present. It can't be zero, anyway, so just |
| complain and ignore it. |
| |
| Signed-off-by: Corey Minyard <cminyard@mvista.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/char/ipmi/ipmi_dmi.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c |
| index e2c143861b1e5..28dbd5529188a 100644 |
| --- a/drivers/char/ipmi/ipmi_dmi.c |
| +++ b/drivers/char/ipmi/ipmi_dmi.c |
| @@ -217,6 +217,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) |
| slave_addr = data[DMI_IPMI_SLAVEADDR]; |
| |
| memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); |
| + if (!base_addr) { |
| + pr_err("Base address is zero, assuming no IPMI interface\n"); |
| + return; |
| + } |
| if (len >= DMI_IPMI_VER2_LENGTH) { |
| if (type == IPMI_DMI_TYPE_SSIF) { |
| offset = 0; |
| -- |
| 2.20.1 |
| |
