| From cbdc2a0143f6f1313748dd2954ad8e16d3d5d83b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 28 Aug 2018 07:07:36 +0000 |
| Subject: ipmi: fix return value of ipmi_set_my_LUN |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 060e8fb53fe3455568982d10ab8c3dd605565049 ] |
| |
| Fixes gcc '-Wunused-but-set-variable' warning: |
| |
| drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_set_my_LUN': |
| drivers/char/ipmi/ipmi_msghandler.c:1335:13: warning: |
| variable 'rv' set but not used [-Wunused-but-set-variable] |
| int index, rv = 0; |
| |
| 'rv' should be the correct return value. |
| |
| Fixes: 048f7c3e352e ("ipmi: Properly release srcu locks on error conditions") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Signed-off-by: Corey Minyard <cminyard@mvista.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/char/ipmi/ipmi_msghandler.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c |
| index 3fb297b5fb176..84c17f936c09c 100644 |
| --- a/drivers/char/ipmi/ipmi_msghandler.c |
| +++ b/drivers/char/ipmi/ipmi_msghandler.c |
| @@ -1365,7 +1365,7 @@ int ipmi_set_my_LUN(struct ipmi_user *user, |
| } |
| release_ipmi_user(user, index); |
| |
| - return 0; |
| + return rv; |
| } |
| EXPORT_SYMBOL(ipmi_set_my_LUN); |
| |
| -- |
| 2.20.1 |
| |