| From c50c869f8d83be8656910ec6760a6993b4ed7d98 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 19 Sep 2018 18:29:58 +0100 |
| Subject: net: hns3: Fix parameter type for q_id in hclge_tm_q_to_qs_map_cfg() |
| |
| From: Jian Shen <shenjian15@huawei.com> |
| |
| [ Upstream commit 32c7fbc8ffd752c6aa05d2dd7c13b0f0aa00ddaa ] |
| |
| So far all the places calling hclge_tm_q_to_qs_map_cfg() are assigning |
| an u16 type value to "q_id", and in the processing of |
| hclge_tm_q_to_qs_map_cfg(), it also converts the "q_id" to le16. |
| |
| The max tqp number for pf can be more than 256, we should use "u16" to |
| store the queue id, instead of "u8", which may cause data lost. |
| |
| Fixes: 848440544b41 ("net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver") |
| Signed-off-by: Jian Shen <shenjian15@huawei.com> |
| Signed-off-by: Peng Li <lipeng321@huawei.com> |
| Signed-off-by: Salil Mehta <salil.mehta@huawei.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c |
| index 11e9259ca0407..0d45d045706c7 100644 |
| --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c |
| +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c |
| @@ -298,7 +298,7 @@ static int hclge_tm_qs_to_pri_map_cfg(struct hclge_dev *hdev, |
| } |
| |
| static int hclge_tm_q_to_qs_map_cfg(struct hclge_dev *hdev, |
| - u8 q_id, u16 qs_id) |
| + u16 q_id, u16 qs_id) |
| { |
| struct hclge_nq_to_qs_link_cmd *map; |
| struct hclge_desc desc; |
| -- |
| 2.20.1 |
| |
