| From 980dd99f86dd5aa70f73ee9afe25561bdf7e1645 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 20 Jul 2018 10:01:58 -0500 |
| Subject: PCI: mediatek: Fix unchecked return value |
| |
| From: Gustavo A. R. Silva <gustavo@embeddedor.com> |
| |
| [ Upstream commit 17a0a1e5f6c4bd6df17834312ff577c1373d87b8 ] |
| |
| Check return value of devm_pci_remap_iospace(). |
| |
| Addresses-Coverity-ID: 1471965 ("Unchecked return value") |
| Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> |
| Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
| Acked-by: Honghui Zhang <honghui.zhang@mediatek.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pci/controller/pcie-mediatek.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c |
| index c5ff6ca65eab2..0d100f56cb884 100644 |
| --- a/drivers/pci/controller/pcie-mediatek.c |
| +++ b/drivers/pci/controller/pcie-mediatek.c |
| @@ -1120,7 +1120,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie) |
| if (err < 0) |
| return err; |
| |
| - devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); |
| + err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); |
| + if (err) |
| + return err; |
| |
| return 0; |
| } |
| -- |
| 2.20.1 |
| |
