| From 830752a0749904eb9bd61d5e144b09e576331953 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 20 Aug 2018 13:48:31 -0500 |
| Subject: rtl8187: Fix warning generated when strncpy() destination length |
| matches the sixe argument |
| |
| From: Larry Finger <Larry.Finger@lwfinger.net> |
| |
| [ Upstream commit 199ba9faca909e77ac533449ecd1248123ce89e7 ] |
| |
| In gcc8, when the 3rd argument (size) of a call to strncpy() matches the |
| length of the first argument, the compiler warns of the possibility of an |
| unterminated string. Using strlcpy() forces a null at the end. |
| |
| Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c |
| index c2d5b495c179a..c089540116fa7 100644 |
| --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c |
| +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c |
| @@ -146,7 +146,7 @@ static int rtl8187_register_led(struct ieee80211_hw *dev, |
| led->dev = dev; |
| led->ledpin = ledpin; |
| led->is_radio = is_radio; |
| - strncpy(led->name, name, sizeof(led->name)); |
| + strlcpy(led->name, name, sizeof(led->name)); |
| |
| led->led_dev.name = led->name; |
| led->led_dev.default_trigger = default_trigger; |
| -- |
| 2.20.1 |
| |
