| From b10a6cabf4b10886b87c474b668d3a804d96c78c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 7 Aug 2018 11:54:50 +0530 |
| Subject: soundwire: intel: Fix uninitialized adev deref |
| |
| From: Vinod Koul <vkoul@kernel.org> |
| |
| [ Upstream commit e1c815f4b24a305e5bc9eceb541674bf4d02b709 ] |
| |
| In case of error, we can dereference uninitialized 'adev' |
| |
| drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb() |
| error: uninitialized symbol 'adev'. |
| |
| Fix that by not using adev for warn print and make it pr_err. |
| |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/soundwire/intel_init.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c |
| index d1ea6b4d0ad30..5c8a20d998786 100644 |
| --- a/drivers/soundwire/intel_init.c |
| +++ b/drivers/soundwire/intel_init.c |
| @@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level, |
| struct acpi_device *adev; |
| |
| if (acpi_bus_get_device(handle, &adev)) { |
| - dev_err(&adev->dev, "Couldn't find ACPI handle\n"); |
| + pr_err("%s: Couldn't find ACPI handle\n", __func__); |
| return AE_NOT_FOUND; |
| } |
| |
| -- |
| 2.20.1 |
| |
