| From 7d29ef6f0120ed802f1e35f7d2a8010e7dca0290 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 2 Aug 2018 00:14:00 +0300 |
| Subject: usb: gadget: uvc: configfs: Drop leaked references to config items |
| |
| From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| |
| [ Upstream commit 86f3daed59bceb4fa7981d85e89f63ebbae1d561 ] |
| |
| Some of the .allow_link() and .drop_link() operations implementations |
| call config_group_find_item() and then leak the reference to the |
| returned item. Fix this by dropping those references where needed. |
| |
| Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/gadget/function/uvc_configfs.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c |
| index b51f0d2788269..dc4edba95a478 100644 |
| --- a/drivers/usb/gadget/function/uvc_configfs.c |
| +++ b/drivers/usb/gadget/function/uvc_configfs.c |
| @@ -544,6 +544,7 @@ static int uvcg_control_class_allow_link(struct config_item *src, |
| unlock: |
| mutex_unlock(&opts->lock); |
| out: |
| + config_item_put(header); |
| mutex_unlock(su_mutex); |
| return ret; |
| } |
| @@ -579,6 +580,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, |
| unlock: |
| mutex_unlock(&opts->lock); |
| out: |
| + config_item_put(header); |
| mutex_unlock(su_mutex); |
| } |
| |
| @@ -2038,6 +2040,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src, |
| unlock: |
| mutex_unlock(&opts->lock); |
| out: |
| + config_item_put(header); |
| mutex_unlock(su_mutex); |
| return ret; |
| } |
| @@ -2078,6 +2081,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, |
| unlock: |
| mutex_unlock(&opts->lock); |
| out: |
| + config_item_put(header); |
| mutex_unlock(su_mutex); |
| } |
| |
| -- |
| 2.20.1 |
| |
