| From c6db9b05b3a3d017b4f994fdaed01f271b518446 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 3 Dec 2018 14:26:55 -0800 |
| Subject: mwifiex: debugfs: correct histogram spacing, formatting |
| |
| From: Brian Norris <briannorris@chromium.org> |
| |
| [ Upstream commit 4cb777c64e030778c569f605398d7604d8aabc0f ] |
| |
| Currently, snippets of this file look like: |
| |
| rx rates (in Mbps): 0=1M 1=2M2=5.5M 3=11M 4=6M 5=9M 6=12M |
| 7=18M 8=24M 9=36M 10=48M 11=54M12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40) |
| 44-53=MCS0-9(VHT:BW20)54-63=MCS0-9(VHT:BW40)64-73=MCS0-9(VHT:BW80) |
| ... |
| noise_flr[--96dBm] = 22 |
| noise_flr[--95dBm] = 149 |
| noise_flr[--94dBm] = 9 |
| noise_flr[--93dBm] = 2 |
| |
| We're missing some spaces, and we're adding a minus sign ('-') on values |
| that are already negative signed integers. |
| |
| Signed-off-by: Brian Norris <briannorris@chromium.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/marvell/mwifiex/debugfs.c | 14 ++++++-------- |
| 1 file changed, 6 insertions(+), 8 deletions(-) |
| |
| diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c |
| index cce70252fd96b..cbe4493b32664 100644 |
| --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c |
| +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c |
| @@ -273,15 +273,13 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, |
| "total samples = %d\n", |
| atomic_read(&phist_data->num_samples)); |
| |
| - p += sprintf(p, "rx rates (in Mbps): 0=1M 1=2M"); |
| - p += sprintf(p, "2=5.5M 3=11M 4=6M 5=9M 6=12M\n"); |
| - p += sprintf(p, "7=18M 8=24M 9=36M 10=48M 11=54M"); |
| - p += sprintf(p, "12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n"); |
| + p += sprintf(p, |
| + "rx rates (in Mbps): 0=1M 1=2M 2=5.5M 3=11M 4=6M 5=9M 6=12M\n" |
| + "7=18M 8=24M 9=36M 10=48M 11=54M 12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n"); |
| |
| if (ISSUPP_11ACENABLED(priv->adapter->fw_cap_info)) { |
| - p += sprintf(p, "44-53=MCS0-9(VHT:BW20)"); |
| - p += sprintf(p, "54-63=MCS0-9(VHT:BW40)"); |
| - p += sprintf(p, "64-73=MCS0-9(VHT:BW80)\n\n"); |
| + p += sprintf(p, |
| + "44-53=MCS0-9(VHT:BW20) 54-63=MCS0-9(VHT:BW40) 64-73=MCS0-9(VHT:BW80)\n\n"); |
| } else { |
| p += sprintf(p, "\n"); |
| } |
| @@ -310,7 +308,7 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, |
| for (i = 0; i < MWIFIEX_MAX_NOISE_FLR; i++) { |
| value = atomic_read(&phist_data->noise_flr[i]); |
| if (value) |
| - p += sprintf(p, "noise_flr[-%02ddBm] = %d\n", |
| + p += sprintf(p, "noise_flr[%02ddBm] = %d\n", |
| (int)(i-128), value); |
| } |
| for (i = 0; i < MWIFIEX_MAX_SIG_STRENGTH; i++) { |
| -- |
| 2.20.1 |
| |