| From foo@baz Sun May 27 17:33:38 CEST 2018 |
| From: Michael Chan <michael.chan@broadcom.com> |
| Date: Fri, 9 Mar 2018 23:46:10 -0500 |
| Subject: bnxt_en: Check valid VNIC ID in bnxt_hwrm_vnic_set_tpa(). |
| |
| From: Michael Chan <michael.chan@broadcom.com> |
| |
| [ Upstream commit 3c4fe80b32c685bdc02b280814d0cfe80d441c72 ] |
| |
| During initialization, if we encounter errors, there is a code path that |
| calls bnxt_hwrm_vnic_set_tpa() with invalid VNIC ID. This may cause a |
| warning in firmware logs. |
| |
| Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") |
| Signed-off-by: Michael Chan <michael.chan@broadcom.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c |
| +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c |
| @@ -3401,6 +3401,9 @@ static int bnxt_hwrm_vnic_set_tpa(struct |
| struct bnxt_vnic_info *vnic = &bp->vnic_info[vnic_id]; |
| struct hwrm_vnic_tpa_cfg_input req = {0}; |
| |
| + if (vnic->fw_vnic_id == INVALID_HW_RING_ID) |
| + return 0; |
| + |
| bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_VNIC_TPA_CFG, -1, -1); |
| |
| if (tpa_flags) { |
