| From foo@baz Sun May 27 17:33:38 CEST 2018 |
| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Sat, 10 Mar 2018 17:55:47 -0800 |
| Subject: hwmon: (pmbus/adm1275) Accept negative page register values |
| |
| From: Guenter Roeck <linux@roeck-us.net> |
| |
| [ Upstream commit ecb29abd4cb0670c616fb563a078f25d777ce530 ] |
| |
| A negative page register value means that no page needs to be |
| selected. This is used by status register read operations and needs |
| to be accepted. The failure to do so so results in missed status |
| and limit registers. |
| |
| Fixes: da8e48ab483e1 ("hwmon: (pmbus) Always call _pmbus_read_byte in core driver") |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/hwmon/pmbus/adm1275.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/hwmon/pmbus/adm1275.c |
| +++ b/drivers/hwmon/pmbus/adm1275.c |
| @@ -154,7 +154,7 @@ static int adm1275_read_word_data(struct |
| const struct adm1275_data *data = to_adm1275_data(info); |
| int ret = 0; |
| |
| - if (page) |
| + if (page > 0) |
| return -ENXIO; |
| |
| switch (reg) { |
| @@ -240,7 +240,7 @@ static int adm1275_write_word_data(struc |
| const struct adm1275_data *data = to_adm1275_data(info); |
| int ret; |
| |
| - if (page) |
| + if (page > 0) |
| return -ENXIO; |
| |
| switch (reg) { |
