| From foo@baz Sun May 27 17:33:38 CEST 2018 |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Sun, 1 Apr 2018 10:26:30 -0700 |
| Subject: net: bgmac: Fix endian access in bgmac_dma_tx_ring_free() |
| |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| |
| [ Upstream commit 60d6e6f0b9e422dd01aeda39257ee0428e5e2a3f ] |
| |
| bgmac_dma_tx_ring_free() assigns the ctl1 word which is a litle endian |
| 32-bit word without using proper accessors, fix this, and because a |
| length cannot be negative, use unsigned int while at it. |
| |
| Fixes: 9cde94506eac ("bgmac: implement scatter/gather support") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/broadcom/bgmac.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/broadcom/bgmac.c |
| +++ b/drivers/net/ethernet/broadcom/bgmac.c |
| @@ -529,7 +529,8 @@ static void bgmac_dma_tx_ring_free(struc |
| int i; |
| |
| for (i = 0; i < BGMAC_TX_RING_SLOTS; i++) { |
| - int len = dma_desc[i].ctl1 & BGMAC_DESC_CTL1_LEN; |
| + u32 ctl1 = le32_to_cpu(dma_desc[i].ctl1); |
| + unsigned int len = ctl1 & BGMAC_DESC_CTL1_LEN; |
| |
| slot = &ring->slots[i]; |
| dev_kfree_skb(slot->skb); |
