| From foo@baz Sun May 27 17:33:38 CEST 2018 |
| From: Chien Tin Tung <chien.tin.tung@intel.com> |
| Date: Wed, 21 Mar 2018 13:09:25 -0500 |
| Subject: RDMA/ucma: Correct option size check using optlen |
| |
| From: Chien Tin Tung <chien.tin.tung@intel.com> |
| |
| [ Upstream commit 5f3e3b85cc0a5eae1c46d72e47d3de7bf208d9e2 ] |
| |
| The option size check is using optval instead of optlen |
| causing the set option call to fail. Use the correct |
| field, optlen, for size check. |
| |
| Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size") |
| Signed-off-by: Chien Tin Tung <chien.tin.tung@intel.com> |
| Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com> |
| Reviewed-by: Leon Romanovsky <leonro@mellanox.com> |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/infiniband/core/ucma.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/infiniband/core/ucma.c |
| +++ b/drivers/infiniband/core/ucma.c |
| @@ -1296,7 +1296,7 @@ static ssize_t ucma_set_option(struct uc |
| if (IS_ERR(ctx)) |
| return PTR_ERR(ctx); |
| |
| - if (unlikely(cmd.optval > KMALLOC_MAX_SIZE)) |
| + if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE)) |
| return -EINVAL; |
| |
| optval = memdup_user((void __user *) (unsigned long) cmd.optval, |
