| From beee97a00905b369ba2685a1b9edab25ba1b9078 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 13 Jun 2020 15:44:19 -0500 |
| Subject: ASoC: tegra: Fix reference count leaks. |
| |
| From: Qiushi Wu <wu000273@umn.edu> |
| |
| [ Upstream commit deca195383a6085be62cb453079e03e04d618d6e ] |
| |
| Calling pm_runtime_get_sync increments the counter even in case of |
| failure, causing incorrect ref count if pm_runtime_put is not called in |
| error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. |
| |
| Signed-off-by: Qiushi Wu <wu000273@umn.edu> |
| Reviewed-by: Jon Hunter <jonathanh@nvidia.com> |
| Link: https://lore.kernel.org/r/20200613204422.24484-1-wu000273@umn.edu |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/tegra/tegra30_ahub.c | 4 +++- |
| sound/soc/tegra/tegra30_i2s.c | 4 +++- |
| 2 files changed, 6 insertions(+), 2 deletions(-) |
| |
| diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c |
| index fef3b9a21a667..e441e23a37e4f 100644 |
| --- a/sound/soc/tegra/tegra30_ahub.c |
| +++ b/sound/soc/tegra/tegra30_ahub.c |
| @@ -656,8 +656,10 @@ static int tegra30_ahub_resume(struct device *dev) |
| int ret; |
| |
| ret = pm_runtime_get_sync(dev); |
| - if (ret < 0) |
| + if (ret < 0) { |
| + pm_runtime_put(dev); |
| return ret; |
| + } |
| ret = regcache_sync(ahub->regmap_ahub); |
| ret |= regcache_sync(ahub->regmap_apbif); |
| pm_runtime_put(dev); |
| diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c |
| index 8e55583aa104e..516f37896092c 100644 |
| --- a/sound/soc/tegra/tegra30_i2s.c |
| +++ b/sound/soc/tegra/tegra30_i2s.c |
| @@ -552,8 +552,10 @@ static int tegra30_i2s_resume(struct device *dev) |
| int ret; |
| |
| ret = pm_runtime_get_sync(dev); |
| - if (ret < 0) |
| + if (ret < 0) { |
| + pm_runtime_put(dev); |
| return ret; |
| + } |
| ret = regcache_sync(i2s->regmap); |
| pm_runtime_put(dev); |
| |
| -- |
| 2.25.1 |
| |