| From ee33e1bc3a30f1169ed92a882f812898628cc31d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 15 Jun 2020 16:12:26 +0800 |
| Subject: scsi: iscsi: Do not put host in iscsi_set_flashnode_param() |
| |
| From: Jing Xiangfeng <jingxiangfeng@huawei.com> |
| |
| [ Upstream commit 68e12e5f61354eb42cfffbc20a693153fc39738e ] |
| |
| If scsi_host_lookup() fails we will jump to put_host which may cause a |
| panic. Jump to exit_set_fnode instead. |
| |
| Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com |
| Reviewed-by: Mike Christie <michael.christie@oracle.com> |
| Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/scsi_transport_iscsi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c |
| index 42b97f1196232..c2bce3f6eaace 100644 |
| --- a/drivers/scsi/scsi_transport_iscsi.c |
| +++ b/drivers/scsi/scsi_transport_iscsi.c |
| @@ -3191,7 +3191,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport, |
| pr_err("%s could not find host no %u\n", |
| __func__, ev->u.set_flashnode.host_no); |
| err = -ENODEV; |
| - goto put_host; |
| + goto exit_set_fnode; |
| } |
| |
| idx = ev->u.set_flashnode.flashnode_idx; |
| -- |
| 2.25.1 |
| |
