| From 1d4169834628d18b2392a2da92b7fbf5e8e2ce89 Mon Sep 17 00:00:00 2001 |
| From: Tang Bin <tangbin@cmss.chinamobile.com> |
| Date: Wed, 26 Aug 2020 22:49:31 +0800 |
| Subject: usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() |
| |
| From: Tang Bin <tangbin@cmss.chinamobile.com> |
| |
| commit 1d4169834628d18b2392a2da92b7fbf5e8e2ce89 upstream. |
| |
| If the function platform_get_irq() failed, the negative value |
| returned will not be detected here. So fix error handling in |
| exynos_ohci_probe(). And when get irq failed, the function |
| platform_get_irq() logs an error message, so remove redundant |
| message here. |
| |
| Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver") |
| Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> |
| Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> |
| Link: https://lore.kernel.org/r/20200826144931.1828-1-tangbin@cmss.chinamobile.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/host/ohci-exynos.c | 5 ++--- |
| 1 file changed, 2 insertions(+), 3 deletions(-) |
| |
| --- a/drivers/usb/host/ohci-exynos.c |
| +++ b/drivers/usb/host/ohci-exynos.c |
| @@ -166,9 +166,8 @@ skip_phy: |
| hcd->rsrc_len = resource_size(res); |
| |
| irq = platform_get_irq(pdev, 0); |
| - if (!irq) { |
| - dev_err(&pdev->dev, "Failed to get IRQ\n"); |
| - err = -ENODEV; |
| + if (irq < 0) { |
| + err = irq; |
| goto fail_io; |
| } |
| |
