| From f05fea5b3574a5926c53865eea27139bb40b2f2b Mon Sep 17 00:00:00 2001 |
| From: Gavin Shan <gwshan@linux.vnet.ibm.com> |
| Date: Thu, 19 Jan 2017 10:10:16 +1100 |
| Subject: powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe() |
| |
| From: Gavin Shan <gwshan@linux.vnet.ibm.com> |
| |
| commit f05fea5b3574a5926c53865eea27139bb40b2f2b upstream. |
| |
| In __eeh_clear_pe_frozen_state(), we should pass the flag's value |
| instead of its address to eeh_unfreeze_pe(). The isolated flag is |
| cleared if no error returned from __eeh_clear_pe_frozen_state(). We |
| never observed the error from the function. So the isolated flag should |
| have been always cleared, no real issue is caused because of the misused |
| @flag. |
| |
| This fixes the code by passing the value of @flag to eeh_unfreeze_pe(). |
| |
| Fixes: 5cfb20b96f6 ("powerpc/eeh: Emulate EEH recovery for VFIO devices") |
| Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/powerpc/kernel/eeh_driver.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/arch/powerpc/kernel/eeh_driver.c |
| +++ b/arch/powerpc/kernel/eeh_driver.c |
| @@ -545,7 +545,7 @@ static void *eeh_pe_detach_dev(void *dat |
| static void *__eeh_clear_pe_frozen_state(void *data, void *flag) |
| { |
| struct eeh_pe *pe = (struct eeh_pe *)data; |
| - bool *clear_sw_state = flag; |
| + bool clear_sw_state = *(bool *)flag; |
| int i, rc = 1; |
| |
| for (i = 0; rc && i < 3; i++) |
