| From d6cf7e8335a973f1338eb4949994c0c3ce6d9d34 Mon Sep 17 00:00:00 2001 |
| From: Heiner Kallweit <hkallweit1@gmail.com> |
| Date: Sat, 30 Mar 2019 17:13:24 +0100 |
| Subject: r8169: disable default rx interrupt coalescing on RTL8168 |
| |
| [ Upstream commit 288ac524cf70a8e7ed851a61ed2a9744039dae8d ] |
| |
| It was reported that re-introducing ASPM, in combination with RX |
| interrupt coalescing, results in significantly increased packet |
| latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes |
| the issue. Therefore change the driver's default to disable RX |
| interrupt coalescing. Users still have the option to enable RX |
| coalescing via ethtool. |
| |
| [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496 |
| |
| Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support") |
| Reported-by: Mike Crowe <mac@mcrowe.com> |
| Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/realtek/r8169.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c |
| index 5adb00f521db..365cddbfc684 100644 |
| --- a/drivers/net/ethernet/realtek/r8169.c |
| +++ b/drivers/net/ethernet/realtek/r8169.c |
| @@ -5333,7 +5333,7 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp) |
| tp->cp_cmd |= PktCntrDisable | INTT_1; |
| RTL_W16(tp, CPlusCmd, tp->cp_cmd); |
| |
| - RTL_W16(tp, IntrMitigate, 0x5151); |
| + RTL_W16(tp, IntrMitigate, 0x5100); |
| |
| /* Work around for RxFIFO overflow. */ |
| if (tp->mac_version == RTL_GIGA_MAC_VER_11) { |
| -- |
| 2.19.1 |
| |
