| From af708900e9a48c0aa46070c8a8cdf0608a1d2025 Mon Sep 17 00:00:00 2001 |
| From: Suresh Udipi <sudipi@jp.adit-jv.com> |
| Date: Wed, 24 Apr 2019 21:23:43 +0200 |
| Subject: staging: most: cdev: fix chrdev_region leak in mod_exit |
| |
| From: Suresh Udipi <sudipi@jp.adit-jv.com> |
| |
| commit af708900e9a48c0aa46070c8a8cdf0608a1d2025 upstream. |
| |
| It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 |
| commit [1] missed to fix the memory leak in mod_exit function. |
| |
| Do it now. |
| |
| [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak") |
| [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381 |
| ("staging: most: cdev: fix leak for chrdev_region") |
| |
| Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com> |
| Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> |
| Acked-by: Christian Gromm <christian.gromm@microchip.com> |
| Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak") |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/most/cdev/cdev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/staging/most/cdev/cdev.c |
| +++ b/drivers/staging/most/cdev/cdev.c |
| @@ -549,7 +549,7 @@ static void __exit mod_exit(void) |
| destroy_cdev(c); |
| destroy_channel(c); |
| } |
| - unregister_chrdev_region(comp.devno, 1); |
| + unregister_chrdev_region(comp.devno, CHRDEV_REGION_SIZE); |
| ida_destroy(&comp.minor_id); |
| class_destroy(comp.class); |
| } |
