| From 31adbedbd52cece452a633c569af7ce4a52d3108 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 14 Nov 2021 18:58:50 -0800 |
| Subject: drm/amd/amdgpu: fix potential memleak |
| |
| From: Bernard Zhao <bernard@vivo.com> |
| |
| [ Upstream commit 27dfaedc0d321b4ea4e10c53e4679d6911ab17aa ] |
| |
| In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed |
| There is a potential memleak if not call kobject_put. |
| |
| Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> |
| Signed-off-by: Bernard Zhao <bernard@vivo.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c |
| index 0526dec1d736e..042c85fc528bb 100644 |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c |
| @@ -358,6 +358,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev) |
| "%s", "xgmi_hive_info"); |
| if (ret) { |
| dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n"); |
| + kobject_put(&hive->kobj); |
| kfree(hive); |
| hive = NULL; |
| goto pro_end; |
| -- |
| 2.33.0 |
| |
