| From d0eb6bf38f787e9a57f87bdd8b7378692ef0843f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 3 Nov 2021 01:30:40 +0530 |
| Subject: thermal: core: Reset previous low and high trip during thermal zone |
| init |
| |
| From: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> |
| |
| [ Upstream commit 99b63316c39988039965693f5f43d8b4ccb1c86c ] |
| |
| During the suspend is in process, thermal_zone_device_update bails out |
| thermal zone re-evaluation for any sensor trip violation without |
| setting next valid trip to that sensor. It assumes during resume |
| it will re-evaluate same thermal zone and update trip. But when it is |
| in suspend temperature goes down and on resume path while updating |
| thermal zone if temperature is less than previously violated trip, |
| thermal zone set trip function evaluates the same previous high and |
| previous low trip as new high and low trip. Since there is no change |
| in high/low trip, it bails out from thermal zone set trip API without |
| setting any trip. It leads to a case where sensor high trip or low |
| trip is disabled forever even though thermal zone has a valid high |
| or low trip. |
| |
| During thermal zone device init, reset thermal zone previous high |
| and low trip. It resolves above mentioned scenario. |
| |
| Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> |
| Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/thermal/thermal_core.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c |
| index 17de8a9b991e9..d9e34ac376626 100644 |
| --- a/drivers/thermal/thermal_core.c |
| +++ b/drivers/thermal/thermal_core.c |
| @@ -474,6 +474,8 @@ static void thermal_zone_device_init(struct thermal_zone_device *tz) |
| { |
| struct thermal_instance *pos; |
| tz->temperature = THERMAL_TEMP_INVALID; |
| + tz->prev_low_trip = -INT_MAX; |
| + tz->prev_high_trip = INT_MAX; |
| list_for_each_entry(pos, &tz->thermal_instances, tz_node) |
| pos->initialized = false; |
| } |
| -- |
| 2.33.0 |
| |