| From f7a6021aaf02088870559f82fc13c58cda7fea1a Mon Sep 17 00:00:00 2001 |
| From: Jiasheng Jiang <jiasheng@iscas.ac.cn> |
| Date: Tue, 11 Jan 2022 10:50:48 +0800 |
| Subject: ASoC: cpcap: Check for NULL pointer after calling of_get_child_by_name |
| |
| From: Jiasheng Jiang <jiasheng@iscas.ac.cn> |
| |
| commit f7a6021aaf02088870559f82fc13c58cda7fea1a upstream. |
| |
| If the device does not exist, of_get_child_by_name() will return NULL |
| pointer. |
| And devm_snd_soc_register_component() does not check it. |
| Also, I have noticed that cpcap_codec_driver has not been used yet. |
| Therefore, it should be better to check it in order to avoid the future |
| dereference of the NULL pointer. |
| |
| Fixes: f6cdf2d3445d ("ASoC: cpcap: new codec") |
| Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> |
| Link: https://lore.kernel.org/r/20220111025048.524134-1-jiasheng@iscas.ac.cn |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| sound/soc/codecs/cpcap.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/sound/soc/codecs/cpcap.c |
| +++ b/sound/soc/codecs/cpcap.c |
| @@ -1544,6 +1544,8 @@ static int cpcap_codec_probe(struct plat |
| { |
| struct device_node *codec_node = |
| of_get_child_by_name(pdev->dev.parent->of_node, "audio-codec"); |
| + if (!codec_node) |
| + return -ENODEV; |
| |
| pdev->dev.of_node = codec_node; |
| |
