| From 79c37ca73a6e9a33f7b2b7783ba6af07a448c8a9 Mon Sep 17 00:00:00 2001 |
| From: Miquel Raynal <miquel.raynal@bootlin.com> |
| Date: Tue, 25 Jan 2022 13:14:25 +0100 |
| Subject: net: ieee802154: Return meaningful error codes from the netlink helpers |
| |
| From: Miquel Raynal <miquel.raynal@bootlin.com> |
| |
| commit 79c37ca73a6e9a33f7b2b7783ba6af07a448c8a9 upstream. |
| |
| Returning -1 does not indicate anything useful. |
| |
| Use a standard and meaningful error code instead. |
| |
| Fixes: a26c5fd7622d ("nl802154: add support for security layer") |
| Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> |
| Acked-by: Alexander Aring <aahringo@redhat.com> |
| Link: https://lore.kernel.org/r/20220125121426.848337-6-miquel.raynal@bootlin.com |
| Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/ieee802154/nl802154.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/net/ieee802154/nl802154.c |
| +++ b/net/ieee802154/nl802154.c |
| @@ -1441,7 +1441,7 @@ static int nl802154_send_key(struct sk_b |
| |
| hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); |
| if (!hdr) |
| - return -1; |
| + return -ENOBUFS; |
| |
| if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) |
| goto nla_put_failure; |
| @@ -1634,7 +1634,7 @@ static int nl802154_send_device(struct s |
| |
| hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); |
| if (!hdr) |
| - return -1; |
| + return -ENOBUFS; |
| |
| if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) |
| goto nla_put_failure; |
| @@ -1812,7 +1812,7 @@ static int nl802154_send_devkey(struct s |
| |
| hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); |
| if (!hdr) |
| - return -1; |
| + return -ENOBUFS; |
| |
| if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) |
| goto nla_put_failure; |
| @@ -1988,7 +1988,7 @@ static int nl802154_send_seclevel(struct |
| |
| hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); |
| if (!hdr) |
| - return -1; |
| + return -ENOBUFS; |
| |
| if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) |
| goto nla_put_failure; |
