| From 013e69950319145e4fd7febf9bbd76538670cb78 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 26 Jun 2021 16:59:39 +0100 |
| Subject: ASoC: wm_adsp: Correct wm_coeff_tlv_get handling |
| |
| From: Charles Keepax <ckeepax@opensource.cirrus.com> |
| |
| [ Upstream commit dd6fb8ff2210f74b056bf9234d0605e8c26a8ac0 ] |
| |
| When wm_coeff_tlv_get was updated it was accidentally switch to the _raw |
| version of the helper causing it to ignore the current DSP state it |
| should be checking. Switch the code back to the correct helper so that |
| users can't read the controls when they arn't available. |
| |
| Fixes: 73ecf1a673d3 ("ASoC: wm_adsp: Correct cache handling of new kernel control API") |
| Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> |
| Link: https://lore.kernel.org/r/20210626155941.12251-1-ckeepax@opensource.cirrus.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/codecs/wm_adsp.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c |
| index 3dc119daf2f6..cef05d81c39b 100644 |
| --- a/sound/soc/codecs/wm_adsp.c |
| +++ b/sound/soc/codecs/wm_adsp.c |
| @@ -1213,7 +1213,7 @@ static int wm_coeff_tlv_get(struct snd_kcontrol *kctl, |
| |
| mutex_lock(&ctl->dsp->pwr_lock); |
| |
| - ret = wm_coeff_read_ctrl_raw(ctl, ctl->cache, size); |
| + ret = wm_coeff_read_ctrl(ctl, ctl->cache, size); |
| |
| if (!ret && copy_to_user(bytes, ctl->cache, size)) |
| ret = -EFAULT; |
| -- |
| 2.30.2 |
| |
