| From 5b3ecd812a8f546accd209ac0219522874a482fc Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 15 Jul 2021 18:07:09 +0200 |
| Subject: perf test event_update: Fix memory leak of evlist |
| |
| From: Riccardo Mancini <rickyman7@gmail.com> |
| |
| [ Upstream commit fc56f54f6fcd5337634f4545af6459613129b432 ] |
| |
| ASan reports a memory leak when running: |
| |
| # perf test "49: Synthesize attr update" |
| |
| Caused by evlist not being deleted. |
| |
| This patch adds the missing evlist__delete and removes the |
| perf_cpu_map__put since it's already being deleted by evlist__delete. |
| |
| Signed-off-by: Riccardo Mancini <rickyman7@gmail.com> |
| Fixes: a6e5281780d1da65 ("perf tools: Add event_update event unit type") |
| Cc: Ian Rogers <irogers@google.com> |
| Cc: Jiri Olsa <jolsa@redhat.com> |
| Cc: Mark Rutland <mark.rutland@arm.com> |
| Cc: Namhyung Kim <namhyung@kernel.org> |
| Cc: Peter Zijlstra <peterz@infradead.org> |
| Link: http://lore.kernel.org/lkml/f7994ad63d248f7645f901132d208fadf9f2b7e4.1626343282.git.rickyman7@gmail.com |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/perf/tests/event_update.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c |
| index 656218179222..932ab0740d11 100644 |
| --- a/tools/perf/tests/event_update.c |
| +++ b/tools/perf/tests/event_update.c |
| @@ -118,6 +118,6 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu |
| TEST_ASSERT_VAL("failed to synthesize attr update cpus", |
| !perf_event__synthesize_event_update_cpus(&tmp.tool, evsel, process_event_cpus)); |
| |
| - perf_cpu_map__put(evsel->core.own_cpus); |
| + evlist__delete(evlist); |
| return 0; |
| } |
| -- |
| 2.30.2 |
| |