| From 532d2b8d4eb9874ee48994367547ba1985cceb90 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 1 Jul 2021 10:27:51 +0200 |
| Subject: pwm: sprd: Ensure configuring period and duty_cycle isn't wrongly |
| skipped |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| |
| [ Upstream commit 65e2e6c1c20104ed19060a38f4edbf14e9f9a9a5 ] |
| |
| As the last call to sprd_pwm_apply() might have exited early if |
| state->enabled was false, the values for period and duty_cycle stored in |
| pwm->state might not have been written to hardware and it must be |
| ensured that they are configured before enabling the PWM. |
| |
| Fixes: 8aae4b02e8a6 ("pwm: sprd: Add Spreadtrum PWM support") |
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Signed-off-by: Thierry Reding <thierry.reding@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pwm/pwm-sprd.c | 11 ++++------- |
| 1 file changed, 4 insertions(+), 7 deletions(-) |
| |
| diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c |
| index 98c479dfae31..3041f0b3bbb6 100644 |
| --- a/drivers/pwm/pwm-sprd.c |
| +++ b/drivers/pwm/pwm-sprd.c |
| @@ -183,13 +183,10 @@ static int sprd_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, |
| } |
| } |
| |
| - if (state->period != cstate->period || |
| - state->duty_cycle != cstate->duty_cycle) { |
| - ret = sprd_pwm_config(spc, pwm, state->duty_cycle, |
| - state->period); |
| - if (ret) |
| - return ret; |
| - } |
| + ret = sprd_pwm_config(spc, pwm, state->duty_cycle, |
| + state->period); |
| + if (ret) |
| + return ret; |
| |
| sprd_pwm_write(spc, pwm->hwpwm, SPRD_PWM_ENABLE, 1); |
| } else if (cstate->enabled) { |
| -- |
| 2.30.2 |
| |
