| From 3eb6ea52bc28b00a79422675b42bfb8cf57362ca Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 21 Jul 2021 11:25:16 +0200 |
| Subject: Revert "USB: quirks: ignore remote wake-up on Fibocom L850-GL LTE |
| modem" |
| |
| From: Vincent Palatin <vpalatin@chromium.org> |
| |
| [ Upstream commit f3a1a937f7b240be623d989c8553a6d01465d04f ] |
| |
| This reverts commit 0bd860493f81eb2a46173f6f5e44cc38331c8dbd. |
| |
| While the patch was working as stated,ie preventing the L850-GL LTE modem |
| from crashing on some U3 wake-ups due to a race condition between the |
| host wake-up and the modem-side wake-up, when using the MBIM interface, |
| this would force disabling the USB runtime PM on the device. |
| |
| The increased power consumption is significant for LTE laptops, |
| and given that with decently recent modem firmwares, when the modem hits |
| the bug, it automatically recovers (ie it drops from the bus, but |
| automatically re-enumerates after less than half a second, rather than being |
| stuck until a power cycle as it was doing with ancient firmware), for |
| most people, the trade-off now seems in favor of re-enabling it by |
| default. |
| |
| For people with access to the platform code, the bug can also be worked-around |
| successfully by changing the USB3 LFPM polling off-time for the XHCI |
| controller in the BIOS code. |
| |
| Signed-off-by: Vincent Palatin <vpalatin@chromium.org> |
| Link: https://lore.kernel.org/r/20210721092516.2775971-1-vpalatin@chromium.org |
| Fixes: 0bd860493f81 ("USB: quirks: ignore remote wake-up on Fibocom L850-GL LTE modem") |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/core/quirks.c | 4 ---- |
| 1 file changed, 4 deletions(-) |
| |
| diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c |
| index 21e7522655ac..a54a735b6384 100644 |
| --- a/drivers/usb/core/quirks.c |
| +++ b/drivers/usb/core/quirks.c |
| @@ -502,10 +502,6 @@ static const struct usb_device_id usb_quirk_list[] = { |
| /* DJI CineSSD */ |
| { USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM }, |
| |
| - /* Fibocom L850-GL LTE Modem */ |
| - { USB_DEVICE(0x2cb7, 0x0007), .driver_info = |
| - USB_QUIRK_IGNORE_REMOTE_WAKEUP }, |
| - |
| /* INTEL VALUE SSD */ |
| { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, |
| |
| -- |
| 2.30.2 |
| |
