| From 57560ee95cb7f91cf0bc31d4ae8276e0dcfe17aa Mon Sep 17 00:00:00 2001 |
| From: Martin Kepplinger <martin.kepplinger@puri.sm> |
| Date: Wed, 14 Jul 2021 08:18:07 +0200 |
| Subject: usb: typec: tipd: Don't block probing of consumer of "connector" nodes |
| |
| From: Martin Kepplinger <martin.kepplinger@puri.sm> |
| |
| commit 57560ee95cb7f91cf0bc31d4ae8276e0dcfe17aa upstream. |
| |
| Similar as with tcpm this patch lets fw_devlink know not to wait on the |
| fwnode to be populated as a struct device. |
| |
| Without this patch, USB functionality can be broken on some previously |
| supported boards. |
| |
| Fixes: 28ec344bb891 ("usb: typec: tcpm: Don't block probing of consumers of "connector" nodes") |
| Cc: stable <stable@vger.kernel.org> |
| Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> |
| Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> |
| Link: https://lore.kernel.org/r/20210714061807.5737-1-martin.kepplinger@puri.sm |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/usb/typec/tipd/core.c | 9 +++++++++ |
| 1 file changed, 9 insertions(+) |
| |
| --- a/drivers/usb/typec/tipd/core.c |
| +++ b/drivers/usb/typec/tipd/core.c |
| @@ -629,6 +629,15 @@ static int tps6598x_probe(struct i2c_cli |
| if (!fwnode) |
| return -ENODEV; |
| |
| + /* |
| + * This fwnode has a "compatible" property, but is never populated as a |
| + * struct device. Instead we simply parse it to read the properties. |
| + * This breaks fw_devlink=on. To maintain backward compatibility |
| + * with existing DT files, we work around this by deleting any |
| + * fwnode_links to/from this fwnode. |
| + */ |
| + fw_devlink_purge_absent_suppliers(fwnode); |
| + |
| tps->role_sw = fwnode_usb_role_switch_get(fwnode); |
| if (IS_ERR(tps->role_sw)) { |
| ret = PTR_ERR(tps->role_sw); |
