| From 4fb51538df618e94f0647598387cdddfda76c271 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 12 Oct 2020 05:10:51 -0400 |
| Subject: bnxt_en: Log unknown link speed appropriately. |
| |
| From: Michael Chan <michael.chan@broadcom.com> |
| |
| [ Upstream commit 8eddb3e7ce124dd6375d3664f1aae13873318b0f ] |
| |
| If the VF virtual link is set to always enabled, the speed may be |
| unknown when the physical link is down. The driver currently logs |
| the link speed as 4294967295 Mbps which is SPEED_UNKNOWN. Modify |
| the link up log message as "speed unknown" which makes more sense. |
| |
| Reviewed-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com> |
| Reviewed-by: Edwin Peer <edwin.peer@broadcom.com> |
| Signed-off-by: Michael Chan <michael.chan@broadcom.com> |
| Link: https://lore.kernel.org/r/1602493854-29283-7-git-send-email-michael.chan@broadcom.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++++- |
| 1 file changed, 5 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c |
| index 7b5d521924872..b8d534b719d4f 100644 |
| --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c |
| +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c |
| @@ -8735,6 +8735,11 @@ static void bnxt_report_link(struct bnxt *bp) |
| u16 fec; |
| |
| netif_carrier_on(bp->dev); |
| + speed = bnxt_fw_to_ethtool_speed(bp->link_info.link_speed); |
| + if (speed == SPEED_UNKNOWN) { |
| + netdev_info(bp->dev, "NIC Link is Up, speed unknown\n"); |
| + return; |
| + } |
| if (bp->link_info.duplex == BNXT_LINK_DUPLEX_FULL) |
| duplex = "full"; |
| else |
| @@ -8747,7 +8752,6 @@ static void bnxt_report_link(struct bnxt *bp) |
| flow_ctrl = "ON - receive"; |
| else |
| flow_ctrl = "none"; |
| - speed = bnxt_fw_to_ethtool_speed(bp->link_info.link_speed); |
| netdev_info(bp->dev, "NIC Link is Up, %u Mbps %s duplex, Flow control: %s\n", |
| speed, duplex, flow_ctrl); |
| if (bp->flags & BNXT_FLAG_EEE_CAP) |
| -- |
| 2.27.0 |
| |
