| From c9e87161cc621cbdcfc472fa0b2d81c63780c8f5 Mon Sep 17 00:00:00 2001 |
| From: Dinghao Liu <dinghao.liu@zju.edu.cn> |
| Date: Sat, 29 Aug 2020 10:54:02 +0800 |
| Subject: ext4: fix error handling code in add_new_gdb |
| |
| From: Dinghao Liu <dinghao.liu@zju.edu.cn> |
| |
| commit c9e87161cc621cbdcfc472fa0b2d81c63780c8f5 upstream. |
| |
| When ext4_journal_get_write_access() fails, we should |
| terminate the execution flow and release n_group_desc, |
| iloc.bh, dind and gdb_bh. |
| |
| Cc: stable@kernel.org |
| Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> |
| Reviewed-by: Andreas Dilger <adilger@dilger.ca> |
| Link: https://lore.kernel.org/r/20200829025403.3139-1-dinghao.liu@zju.edu.cn |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/ext4/resize.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/fs/ext4/resize.c |
| +++ b/fs/ext4/resize.c |
| @@ -843,8 +843,10 @@ static int add_new_gdb(handle_t *handle, |
| |
| BUFFER_TRACE(dind, "get_write_access"); |
| err = ext4_journal_get_write_access(handle, dind); |
| - if (unlikely(err)) |
| + if (unlikely(err)) { |
| ext4_std_error(sb, err); |
| + goto errout; |
| + } |
| |
| /* ext4_reserve_inode_write() gets a reference on the iloc */ |
| err = ext4_reserve_inode_write(handle, inode, &iloc); |
