| From b860e2a3a353b7ff780c85150f0ce6ac9a934941 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 25 Sep 2020 10:09:58 -0400 |
| Subject: nfsd4: remove check_conflicting_opens warning |
| |
| From: J. Bruce Fields <bfields@redhat.com> |
| |
| [ Upstream commit 50747dd5e47bde3b7d7f839c84d0d3b554090497 ] |
| |
| There are actually rare races where this is possible (e.g. if a new open |
| intervenes between the read of i_writecount and the fi_fds). |
| |
| Signed-off-by: J. Bruce Fields <bfields@redhat.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/nfsd/nfs4state.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c |
| index 0525acfe31314..1f646a27481fb 100644 |
| --- a/fs/nfsd/nfs4state.c |
| +++ b/fs/nfsd/nfs4state.c |
| @@ -4954,7 +4954,6 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp, |
| writes--; |
| if (fp->fi_fds[O_RDWR]) |
| writes--; |
| - WARN_ON_ONCE(writes < 0); |
| if (writes > 0) |
| return -EAGAIN; |
| spin_lock(&fp->fi_lock); |
| -- |
| 2.27.0 |
| |
