| From ea9edc65049907f2b2c9e140938bd09e6b6511b8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 20 Jul 2020 12:18:45 -0700 |
| Subject: video: fbdev: pvr2fb: initialize variables |
| |
| From: Tom Rix <trix@redhat.com> |
| |
| [ Upstream commit 8e1ba47c60bcd325fdd097cd76054639155e5d2e ] |
| |
| clang static analysis reports this repesentative error |
| |
| pvr2fb.c:1049:2: warning: 1st function call argument |
| is an uninitialized value [core.CallAndMessage] |
| if (*cable_arg) |
| ^~~~~~~~~~~~~~~ |
| |
| Problem is that cable_arg depends on the input loop to |
| set the cable_arg[0]. If it does not, then some random |
| value from the stack is used. |
| |
| A similar problem exists for output_arg. |
| |
| So initialize cable_arg and output_arg. |
| |
| Signed-off-by: Tom Rix <trix@redhat.com> |
| Acked-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Sam Ravnborg <sam@ravnborg.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/pvr2fb.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c |
| index 2d9f69b93392a..f4add36cb5f4d 100644 |
| --- a/drivers/video/fbdev/pvr2fb.c |
| +++ b/drivers/video/fbdev/pvr2fb.c |
| @@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options) |
| if (!options || !*options) |
| return 0; |
| |
| + cable_arg[0] = output_arg[0] = 0; |
| + |
| while ((this_opt = strsep(&options, ","))) { |
| if (!*this_opt) |
| continue; |
| -- |
| 2.27.0 |
| |
