| From foo@baz Mon Jul 4 04:42:02 PM CEST 2022 |
| From: Amir Goldstein <amir73il@gmail.com> |
| Date: Sun, 3 Jul 2022 08:04:56 +0300 |
| Subject: xfs: fix xfs_reflink_unshare usage of filemap_write_and_wait_range |
| To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Cc: Sasha Levin <sashal@kernel.org>, "Darrick J . Wong" <djwong@kernel.org>, Leah Rumancik <leah.rumancik@gmail.com>, Chandan Babu R <chandan.babu@oracle.com>, Luis Chamberlain <mcgrof@kernel.org>, Adam Manzanares <a.manzanares@samsung.com>, linux-xfs@vger.kernel.org, stable@vger.kernel.org, Chandan Babu R <chandanrlinux@gmail.com>, Brian Foster <bfoster@redhat.com> |
| Message-ID: <20220703050456.3222610-8-amir73il@gmail.com> |
| |
| From: "Darrick J. Wong" <djwong@kernel.org> |
| |
| commit d4f74e162d238ce00a640af5f0611c3f51dad70e upstream. |
| |
| The final parameter of filemap_write_and_wait_range is the end of the |
| range to flush, not the length of the range to flush. |
| |
| Fixes: 46afb0628b86 ("xfs: only flush the unshared range in xfs_reflink_unshare") |
| Signed-off-by: Darrick J. Wong <djwong@kernel.org> |
| Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com> |
| Reviewed-by: Brian Foster <bfoster@redhat.com> |
| Signed-off-by: Amir Goldstein <amir73il@gmail.com> |
| Acked-by: Darrick J. Wong <djwong@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/xfs/xfs_reflink.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/fs/xfs/xfs_reflink.c |
| +++ b/fs/xfs/xfs_reflink.c |
| @@ -1503,7 +1503,8 @@ xfs_reflink_unshare( |
| if (error) |
| goto out; |
| |
| - error = filemap_write_and_wait_range(inode->i_mapping, offset, len); |
| + error = filemap_write_and_wait_range(inode->i_mapping, offset, |
| + offset + len - 1); |
| if (error) |
| goto out; |
| |
