| From foo@baz Sun Jan 10 02:09:05 PM CET 2021 |
| From: Yunjian Wang <wangyunjian@huawei.com> |
| Date: Sat, 26 Dec 2020 16:10:05 +0800 |
| Subject: net: hns: fix return value check in __lb_other_process() |
| |
| From: Yunjian Wang <wangyunjian@huawei.com> |
| |
| [ Upstream commit 5ede3ada3da7f050519112b81badc058190b9f9f ] |
| |
| The function skb_copy() could return NULL, the return value |
| need to be checked. |
| |
| Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support") |
| Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c |
| +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c |
| @@ -433,6 +433,10 @@ static void __lb_other_process(struct hn |
| /* for mutl buffer*/ |
| new_skb = skb_copy(skb, GFP_ATOMIC); |
| dev_kfree_skb_any(skb); |
| + if (!new_skb) { |
| + netdev_err(ndev, "skb alloc failed\n"); |
| + return; |
| + } |
| skb = new_skb; |
| |
| check_ok = 0; |
